Refactor: define CLI with click #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
thekaveman
force-pushed
the
refactor/click-cli
branch
from
82e4e3b to
f4a4a04
Compare
thekaveman
force-pushed
the
feat/justworks
branch
2 times, most recently
from
147b26d to
98f0b7c
Compare
thekaveman
force-pushed
the
refactor/click-cli
branch
3 times, most recently
from
abca56c to
3039112
Compare
thekaveman
force-pushed
the
refactor/click-cli
branch
from
3039112 to
3c0cabc
Compare
|
Used the newly refactored CLI to do the hours download and conversion today -- worked without any issues 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
Completely rewrites the CLI commands away from manual
argparseconstruction to use@click.commandand@click.groupdefinitions.This lead to a massive simplification of the tests as well☺️